From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Remove dead code for temporary relations in partition planning |
Date: | 2018-07-04 01:48:40 |
Message-ID: | E1faWuO-0004Wo-4x@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Remove dead code for temporary relations in partition planning
Since recent commit 1c7c317c, temporary relations cannot be mixed with
permanent relations within the same partition tree, and the same counts
for temporary relations created by other sessions, which the planner
simply discarded. Instead be paranoid and issue an error, as those
should be blocked at definition time, at least for now.
At the same time, a test case is added to stress what has been moved
when expand_partitioned_rtentry gets called recursively but bumps on a
partitioned relation with no partitions which should be handled the same
way as the non-inheritance case. This code may be reworked in a close
future, and covering this code path will limit surprises.
Reported-by: David Rowley
Author: David Rowley
Reviewed-by: Amit Langote, Robert Haas, Michael Paquier
Discussion: https://postgr.es/m/CAKJS1f_HyV1txn_4XSdH5EOhBMYaCwsXyAj6bHXk9gOu4JKsbw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fc057b2b8fc3c3556d9f8cc0195c622aaad92c9e
Modified Files
--------------
src/backend/optimizer/prep/prepunion.c | 33 ++++++++++++++++-----------------
src/test/regress/expected/select.out | 13 +++++++++++++
src/test/regress/sql/select.sql | 8 ++++++++
3 files changed, 37 insertions(+), 17 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-07-04 01:48:52 | Re: pgsql: Clarify use of temporary tables within partition trees |
Previous Message | Amit Langote | 2018-07-04 01:24:15 | Re: pgsql: Clarify use of temporary tables within partition trees |