| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Correct handling of fsync failures with tar mode of walmethods.c |
| Date: | 2018-06-26 00:57:42 |
| Message-ID: | E1fXcIg-0005vq-2Y@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Correct handling of fsync failures with tar mode of walmethods.c
This file has been missing the fact that it needs to report back to
callers a proper failure on fsync calls. I have spotted the one in
tar_finish() while Kuntal has spotted the one in tar_close().
Backpatch down to 10 where this code has been introduced.
Reported by: Michael Paquier, Kuntal Ghosh
Author: Michael Paquier
Reviewed-by: Kuntal Ghosh, Magnus Hagander
Discussion: https://postgr.es/m/20180625024356.GD1146@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d08c3d5197fac1f49cedbd8417e685479ad7439a
Modified Files
--------------
src/bin/pg_basebackup/walmethods.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-06-26 06:01:46 | pgsql: Fix description and documentation related to pg_restore --no-com |
| Previous Message | Alvaro Herrera | 2018-06-25 19:46:49 | pgsql: Update obsolete comments |