pgsql: Fix mishandling of sortgroupref labels while splitting SRF targe

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix mishandling of sortgroupref labels while splitting SRF targe
Date: 2018-06-21 14:58:55
Message-ID: E1fW131-0006AW-Gt@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix mishandling of sortgroupref labels while splitting SRF targetlists.

split_pathtarget_at_srfs() neglected to worry about sortgroupref labels
in the intermediate PathTargets it constructs. I think we'd supposed
that their labeling didn't matter, but it does at least for the case that
GroupAggregate/GatherMerge nodes appear immediately under the ProjectSet
step(s). This results in "ERROR: ORDER/GROUP BY expression not found in
targetlist" during create_plan(), as reported by Rajkumar Raghuwanshi.

To fix, make this logic track the sortgroupref labeling of expressions,
not just their contents. This also restores the pre-v10 behavior that
separate GROUP BY expressions will be kept distinct even if they are
textually equal().

Discussion: https://postgr.es/m/CAKcux6=1_Ye9kx8YLBPmJs_xE72PPc6vNi5q2AOHowMaCWjJ2w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07e5a213524853c06684155d4af5a0291d95d25a

Modified Files
--------------
src/backend/optimizer/util/tlist.c | 146 +++++++++++++++++++++++---
src/test/regress/expected/select_parallel.out | 62 +++++++++++
src/test/regress/sql/select_parallel.sql | 7 ++
3 files changed, 198 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-06-21 16:37:26 pgsql: Improve requirements documentation for ldap test suite.
Previous Message Alexander Korotkov 2018-06-21 12:53:50 pgsql: Improve wording of release notes item