| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | pgAgent commit: 1. Connection object was being accessed, which was alre |
| Date: | 2018-06-11 16:14:12 |
| Message-ID: | E1fSPSO-0007Kh-DP@gothos.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
1. Connection object was being accessed, which was already released.
2. Changed the logic for checking the connection object existence.
We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for the 'DBconn' class.
I suspect some compilers (specifically windows one) may not behave that way, and instead of using the boolean operator, it checks for the pointer is NULL or not.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=1c583df4bbf0a3f15a5f919096057cca70da1237
Author: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Modified Files
--------------
connection.cpp | 2 +-
pgAgent.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-06-11 16:14:24 | Re: [PATCH] pgAgent segfault |
| Previous Message | Dave Page | 2018-06-11 16:03:34 | Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node |