pgsql: Don't fall off the end of perl functions

Don't fall off the end of perl functions

This complies with the perlcritic policy
Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we
only currently check at severity level 5, the policy is raised to that
level until we move to level 4 or lower, so that any new infringements
will be caught.

A small cosmetic piece of tidying of the pgperlcritic script is
included.

Mike Blackwell

Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3a7cc727c7c502353dbb730a0db793abec4de44b

Modified Files
--------------
contrib/bloom/t/001_wal.pl | 1 +
contrib/intarray/bench/create_test.pl | 1 +
src/backend/catalog/Catalog.pm | 1 +
src/backend/catalog/genbki.pl | 4 +++
src/backend/parser/check_keywords.pl | 1 +
src/backend/utils/mb/Unicode/convutils.pm | 5 ++++
src/backend/utils/sort/gen_qsort_tuple.pl | 4 +++
.../pg_archivecleanup/t/010_pg_archivecleanup.pl | 2 ++
src/bin/pg_rewind/RewindTest.pm | 13 ++++++++++
src/bin/pg_rewind/t/001_basic.pl | 1 +
src/bin/pg_rewind/t/002_databases.pl | 1 +
src/bin/pg_rewind/t/003_extrafiles.pl | 1 +
src/bin/pg_rewind/t/004_pg_xlog_symlink.pl | 1 +
src/bin/pgbench/t/001_pgbench_with_server.pl | 3 +++
src/bin/pgbench/t/002_pgbench_no_server.pl | 2 ++
src/include/catalog/reformat_dat_file.pl | 1 +
src/interfaces/ecpg/preproc/parse.pl | 6 +++++
src/pl/plperl/plc_perlboot.pl | 1 +
src/pl/plperl/text2macro.pl | 1 +
src/test/authentication/t/001_password.pl | 2 ++
src/test/authentication/t/002_saslprep.pl | 2 ++
src/test/kerberos/t/001_auth.pl | 1 +
src/test/ldap/t/001_auth.pl | 1 +
src/test/perl/PostgresNode.pm | 30 +++++++++++++++++++++-
src/test/perl/SimpleTee.pm | 2 +-
src/test/perl/TestLib.pm | 14 ++++++++++
src/test/recovery/t/001_stream_rep.pl | 3 +++
src/test/recovery/t/003_recovery_targets.pl | 2 ++
src/test/recovery/t/007_sync_rep.pl | 1 +
src/test/recovery/t/009_twophase.pl | 1 +
src/test/ssl/ServerSetup.pm | 9 +++++++
src/tools/copyright.pl | 1 +
src/tools/git_changelog | 3 +++
src/tools/msvc/Install.pm | 13 ++++++++++
src/tools/msvc/MSBuildProject.pm | 11 ++++++++
src/tools/msvc/Mkvcbuild.pm | 5 ++++
src/tools/msvc/Project.pm | 15 +++++++++++
src/tools/msvc/Solution.pm | 5 ++++
src/tools/msvc/VCBuildProject.pm | 5 ++++
src/tools/msvc/builddoc.pl | 2 +-
src/tools/msvc/gendef.pl | 3 +++
src/tools/msvc/vcregress.pl | 14 ++++++++++
src/tools/pginclude/pgcheckdefines | 2 ++
src/tools/pgindent/pgindent | 7 +++++
src/tools/pgperlcritic/perlcriticrc | 5 ++++
src/tools/pgperlcritic/pgperlcritic | 2 +-
src/tools/version_stamp.pl | 1 +
47 files changed, 208 insertions(+), 4 deletions(-)