From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Remove configure's check for nonstandard "long long" printf modi |
Date: | 2018-05-23 18:20:16 |
Message-ID: | E1fLYMy-000771-21@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Remove configure's check for nonstandard "long long" printf modifiers.
We used to claim to support platforms using 'q' or 'I64' as the printf
length modifier for long long int, by dint of replacing snprintf with
our own code which uses the C99 standard 'll' modifier. But that is
only adequate if we use INT64_MODIFIER only in snprintf-based calls,
not directly with the platform's native printf or fprintf. Which
hasn't been the case for years. We had not noticed, partially because
of inadequate test coverage, and partially because the buildfarm is
almost completely bare of machines that won't take 'll'. The last
one seems to have been frogmouth, which was adjusted recently so that
it will take 'll'. We might as well just give up on the pretense
that anything else works, and save ourselves some configure cycles.
Discussion: https://postgr.es/m/13103.1526749980@sss.pgh.pa.us
Discussion: https://postgr.es/m/24769.1526772680@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b929614f5e867c70721b3db31d3dec6cb35e1eb5
Modified Files
--------------
config/c-library.m4 | 55 --------------------------
configure | 92 +++++--------------------------------------
configure.in | 51 ++++++------------------
src/include/pg_config.h.in | 2 +-
src/include/pg_config.h.win32 | 2 +-
5 files changed, 24 insertions(+), 178 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-05-23 23:04:51 | pgsql: Fix simple_prompt() to disable echo on Windows when stdin != ter |
Previous Message | Tom Lane | 2018-05-23 15:00:02 | pgsql: Fix incorrect ordering of operations in pg_resetwal and pg_rewin |