pgsql: Assorted minor cleanups for bootstrap-data Perl scripts.

Assorted minor cleanups for bootstrap-data Perl scripts.

FindDefinedSymbol was intended to take an array of possible include
paths, but it never actually worked correctly for any but the first
array element. Since there's no use-case for more than one path
anyway, let's just simplify this code and its callers by redefining
it as taking only one include path.

Minor other code-beautification without functional effects, except
that in one place we format the output as pgindent would do.

John Naylor

Discussion: https://postgr.es/m/CAJVSVGXM_n32hTTkircW4_K1LQFsJNb6xjs0pAP4QC0ZpyJfPQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e7a808f947c66e2e2186c9495359865dadaf511a

Modified Files
--------------
src/backend/catalog/Catalog.pm | 38 ++++++++++++++------------------
src/backend/catalog/genbki.pl | 5 ++---
src/backend/utils/Gen_fmgrtab.pl | 32 +++++++++++++--------------
src/include/catalog/reformat_dat_file.pl | 1 -
src/include/catalog/unused_oids | 2 +-
5 files changed, 36 insertions(+), 42 deletions(-)