pgsql: Improve jsonb cast error message

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve jsonb cast error message
Date: 2018-05-09 10:23:43
Message-ID: E1fGMG7-0007uT-J9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve jsonb cast error message

Initial variant of error message didn't follow style of another casting error
messages and wasn't informative. Per gripe from Robert Haas.

Reviewer: Tom Lane
Discussion: https://www.postgresql.org/message-id/flat/CA%2BTgmob08StTV9yu04D0idRFNMh%2BUoyKax5Otvrix7rEZC8rMw%40mail(dot)gmail(dot)com#CA+Tgmob08StTV9yu04D0idRFNMh+UoyKax5Otvrix7rEZC8rMw(at)mail(dot)gmail(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cb5d94295986298af666534970f9bb3715574646

Modified Files
--------------
src/backend/utils/adt/jsonb.c | 71 ++++++++++++++++++++++++-------------
src/test/regress/expected/jsonb.out | 8 ++---
2 files changed, 51 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2018-05-09 12:00:03 pgsql: Add a script and a config file to run perlcritic
Previous Message Tom Lane 2018-05-09 00:18:02 pgsql: Improve inefficient regexes in vacuumdb TAP test.