pgsql: Clean up some perlcritic warnings

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clean up some perlcritic warnings
Date: 2018-05-07 20:00:48
Message-ID: E1fFmJU-0003bQ-8j@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clean up some perlcritic warnings

In Catalog.pm, mark eval of a string instead of a block as allowed.
Disallow perlcritic completely in Gen_dummy_probes.pl, as it's
generated code.
Protect a couple of lines in plperl code from perltidy, so that the
annotation for perlcritic stays on the same line as the construct it
would otherwise object to.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d2c1512ac48c1c25dfec07d341e9b74e57f6fbc4

Modified Files
--------------
src/backend/catalog/Catalog.pm | 5 ++++-
src/backend/utils/Gen_dummy_probes.pl | 3 +++
src/pl/plperl/plc_perlboot.pl | 6 +++---
src/pl/plperl/plc_trusted.pl | 5 +++--
4 files changed, 13 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-05-07 20:52:17 pgsql: Stamp 10.4.
Previous Message Tom Lane 2018-05-07 19:12:07 pgsql: Undo extra chattiness of postmaster logs in TAP tests.