From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Does it help to wait before reattaching? |
Date: | 2018-05-01 00:09:37 |
Message-ID: | E1fDIrR-0005gB-Ns@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Does it help to wait before reattaching?
Revert the map/unmap dance I tried in commit 73042b8d1; that helps
not at all.
Instead, speculate that the unwanted allocation is being done on
another thread, and thus timing variations explain the apparent
unpredictability. Temporarily add a 1-second sleep before the
VirtualFree call, in hopes that any such other threads will
quiesce and not jog our elbow.
This is obviously not a desirable long-term fix, but as a means of
investigation it seems useful.
Discussion: https://postgr.es/m/25495.1524517820@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/23078689a9921968ac0873b017be6e7f772f10bc
Modified Files
--------------
src/backend/port/win32_shmem.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-05-01 03:58:54 | pgsql: Tweak new jsonb_plperl test cases to work with old Perl versions |
Previous Message | Tom Lane | 2018-04-30 23:37:18 | Re: pgsql: Prevent infinity and NaN in jsonb/plperl transform |