pgsql: Fix bogus list-iteration code in pg_regress.c, affecting ecpg te

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bogus list-iteration code in pg_regress.c, affecting ecpg te
Date: 2018-04-30 01:56:54
Message-ID: E1fCy3i-0004I2-3L@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus list-iteration code in pg_regress.c, affecting ecpg tests only.

While looking at a recent buildfarm failure in the ecpg tests, I wondered
why the pg_regress output claimed the stderr part of the test failed, when
the regression diffs were clearly for the stdout part. Looking into it,
the reason is that pg_regress.c's logic for iterating over three parallel
lists is wrong, and has been wrong since it was written: it advances the
"tag" pointer at a different place in the loop than the other two pointers.
Fix that.

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d86e9e21058cfd53f0b6a3cabee68446aa255775

Modified Files
--------------
src/test/regress/pg_regress.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-30 15:16:27 pgsql: Dump full memory maps around failing Windows reattach code.
Previous Message Tom Lane 2018-04-30 00:41:25 pgsql: Get still more info about Windows can't-reattach-to-shared-memor