pgsql: Add missing and dangling downlink checks to amcheck

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add missing and dangling downlink checks to amcheck
Date: 2018-04-25 15:03:57
Message-ID: E1fBLxd-0002AN-IG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add missing and dangling downlink checks to amcheck

When bt_index_parent_check() is called with the heapallindexed option,
allocate a second Bloom filter to fingerprint block numbers that appear
in the downlinks of internal pages. Use Bloom filter probes when
walking the B-Tree to detect missing downlinks. This can detect subtle
problems with page deletion/VACUUM, such as corruption caused by the bug
just fixed in commit 6db4b499.

The downlink Bloom filter is bound in size by work_mem. Its optimal
size is typically far smaller than that of the regular heapallindexed
Bloom filter, especially when the index has high fan-out.

Author: Peter Geoghegan
Reviewer: Teodor Sigaev
Discussion: https://postgr.es/m/CAH2-WznUzY4fWTjm1tBB3JpVz8cCfz7k_qVp5BhuPyhivmWJFg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4eaf7eaccb291f5d32d9f05284bfca9c5744de9a

Modified Files
--------------
contrib/amcheck/verify_nbtree.c | 397 ++++++++++++++++++++++++++++++++++++++--
doc/src/sgml/amcheck.sgml | 7 +-
2 files changed, 385 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-25 18:00:31 pgsql: Change pgindent/README to specify that we use perltidy version 2
Previous Message Magnus Hagander 2018-04-25 07:30:19 pgsql: Fix typo