pgsql: Improve consistency of comments in system catalog headers.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve consistency of comments in system catalog headers.
Date: 2018-04-19 21:14:15
Message-ID: E1f9Gsh-0005xs-KG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve consistency of comments in system catalog headers.

Use the term "system catalog" rather than "system relation" in assorted
places where it's clearly referring to a table rather than, say, an
index. Use more natural word order in the header boilerplate, improve
some of the one-liner catalog descriptions, and fix assorted random
deviations from the normal boilerplate. All purely neatnik-ism, but
why not.

John Naylor, some additional cleanup by me

Discussion: https://postgr.es/m/CAJVSVGUeJmFB3h-NJ18P32NPa+kzC165nm7GSoGHfPaN80Wxcw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/68c23cba341a0083afa8e30f0c43bf18cbd01bb7

Modified Files
--------------
src/backend/catalog/genbki.pl | 6 +++---
src/include/catalog/pg_aggregate.dat | 2 +-
src/include/catalog/pg_aggregate.h | 2 +-
src/include/catalog/pg_am.dat | 2 +-
src/include/catalog/pg_am.h | 2 +-
src/include/catalog/pg_amop.dat | 2 +-
src/include/catalog/pg_amop.h | 2 +-
src/include/catalog/pg_amproc.dat | 2 +-
src/include/catalog/pg_amproc.h | 2 +-
src/include/catalog/pg_attrdef.h | 2 +-
src/include/catalog/pg_attribute.h | 2 +-
src/include/catalog/pg_auth_members.h | 2 +-
src/include/catalog/pg_authid.dat | 2 +-
src/include/catalog/pg_authid.h | 2 +-
src/include/catalog/pg_cast.dat | 2 +-
src/include/catalog/pg_cast.h | 6 +++---
src/include/catalog/pg_class.dat | 4 ++--
src/include/catalog/pg_class.h | 2 +-
src/include/catalog/pg_collation.dat | 2 +-
src/include/catalog/pg_collation.h | 5 ++---
src/include/catalog/pg_constraint.h | 2 +-
src/include/catalog/pg_conversion.h | 2 +-
src/include/catalog/pg_database.dat | 2 +-
src/include/catalog/pg_database.h | 2 +-
src/include/catalog/pg_db_role_setting.h | 3 ++-
src/include/catalog/pg_default_acl.h | 3 ++-
src/include/catalog/pg_depend.h | 2 +-
src/include/catalog/pg_description.h | 2 +-
src/include/catalog/pg_enum.h | 5 +++--
src/include/catalog/pg_event_trigger.h | 2 +-
src/include/catalog/pg_extension.h | 2 +-
src/include/catalog/pg_foreign_data_wrapper.h | 2 +-
src/include/catalog/pg_foreign_server.h | 2 +-
src/include/catalog/pg_foreign_table.h | 2 +-
src/include/catalog/pg_index.h | 2 +-
src/include/catalog/pg_inherits.h | 2 +-
src/include/catalog/pg_init_privs.h | 2 +-
src/include/catalog/pg_language.dat | 2 +-
src/include/catalog/pg_language.h | 2 +-
src/include/catalog/pg_largeobject.h | 2 +-
src/include/catalog/pg_largeobject_metadata.h | 3 ++-
src/include/catalog/pg_namespace.dat | 2 +-
src/include/catalog/pg_namespace.h | 2 +-
src/include/catalog/pg_opclass.dat | 2 +-
src/include/catalog/pg_opclass.h | 2 +-
src/include/catalog/pg_operator.dat | 2 +-
src/include/catalog/pg_operator.h | 2 +-
src/include/catalog/pg_opfamily.dat | 2 +-
src/include/catalog/pg_opfamily.h | 2 +-
src/include/catalog/pg_partitioned_table.h | 4 +++-
src/include/catalog/pg_pltemplate.dat | 2 +-
src/include/catalog/pg_pltemplate.h | 2 +-
src/include/catalog/pg_policy.h | 2 +-
src/include/catalog/pg_proc.dat | 2 +-
src/include/catalog/pg_proc.h | 2 +-
src/include/catalog/pg_publication.h | 2 +-
src/include/catalog/pg_publication_rel.h | 5 +++--
src/include/catalog/pg_range.dat | 2 +-
src/include/catalog/pg_range.h | 2 +-
src/include/catalog/pg_replication_origin.h | 3 ++-
src/include/catalog/pg_rewrite.h | 2 +-
src/include/catalog/pg_seclabel.h | 8 +++++++-
src/include/catalog/pg_sequence.h | 8 +++++++-
src/include/catalog/pg_shdepend.h | 2 +-
src/include/catalog/pg_shdescription.h | 2 +-
src/include/catalog/pg_shseclabel.h | 8 +++++++-
src/include/catalog/pg_statistic.h | 2 +-
src/include/catalog/pg_statistic_ext.h | 2 +-
src/include/catalog/pg_subscription.h | 8 +++++++-
src/include/catalog/pg_subscription_rel.h | 10 ++++++++--
src/include/catalog/pg_tablespace.dat | 2 +-
src/include/catalog/pg_tablespace.h | 2 +-
src/include/catalog/pg_transform.h | 2 +-
src/include/catalog/pg_trigger.h | 2 +-
src/include/catalog/pg_ts_config.dat | 2 +-
src/include/catalog/pg_ts_config.h | 3 ++-
src/include/catalog/pg_ts_config_map.dat | 2 +-
src/include/catalog/pg_ts_config_map.h | 3 ++-
src/include/catalog/pg_ts_dict.dat | 2 +-
src/include/catalog/pg_ts_dict.h | 2 +-
src/include/catalog/pg_ts_parser.dat | 2 +-
src/include/catalog/pg_ts_parser.h | 2 +-
src/include/catalog/pg_ts_template.dat | 2 +-
src/include/catalog/pg_ts_template.h | 2 +-
src/include/catalog/pg_type.dat | 2 +-
src/include/catalog/pg_type.h | 2 +-
src/include/catalog/pg_user_mapping.h | 2 +-
87 files changed, 136 insertions(+), 97 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-19 22:29:44 pgsql: Fix broken extract_actual_join_clauses call in 9.6 postgres_fdw.
Previous Message Tom Lane 2018-04-19 19:49:44 pgsql: Fix incorrect handling of join clauses pushed into parameterized