pgsql: Remove quick path in ExecInitPartitionInfo for equal tupdescs

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove quick path in ExecInitPartitionInfo for equal tupdescs
Date: 2018-04-19 19:47:20
Message-ID: E1f9FWa-0004D3-Hq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove quick path in ExecInitPartitionInfo for equal tupdescs

I added this "optimization" on top of Amit Langote's 158b7bc6d779, but
the quick path is never taken because the partition uses a different
pg_type oid than its parent table (causing equalTupleDescs to return
false). Changing that requires more analysis and is too considered
dangerous at this point in the cycle, so revert it.

We might make it work someday, but not for pg11.

Discussion: https://postgr.es/m/825031be-942c-8c24-6163-13c27f217a3d@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/79b2e52615faa768d8436c1795e445541460e9d2

Modified Files
--------------
src/backend/executor/execPartition.c | 153 ++++++++++++++++-------------------
1 file changed, 68 insertions(+), 85 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-19 19:49:44 pgsql: Fix incorrect handling of join clauses pushed into parameterized
Previous Message Alvaro Herrera 2018-04-19 15:39:59 pgsql: Plural of modulus is moduli