pgsql: Improve coverage of nodeAppend runtime partition prune

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve coverage of nodeAppend runtime partition prune
Date: 2018-04-17 15:29:33
Message-ID: E1f8SY1-0000ZE-6T@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve coverage of nodeAppend runtime partition prune

coverage report indicated that mark_invalid_subplans_as_finished() and
nearby code was not getting exercised by any tests. Add a new one which
has execution-time Params rather than only external Params to fix this.

In passing, David noticed that ab_q6 tests were not actually required to
have a generic plan. The tests were testing exec Params not external
Params, so there was no need for the PREPARE. Remove the PREPARE,
making these plain queries. (The new queries are called from
explain_parallel_append, which may be unnecessary since they don't
actually have a Parallel Append node, just an Append. But it doesn't
seem to hurt anything, either.)

Author: David Rowley
Discussion: https://postgr.es/m/CAKJS1f--hopb6JBSDY4wiXTS3ZcDp-wparXjTQ1nzNdBa04Fog@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/95cdc77b35ece28137b8dec8c6f9b5474b215624

Modified Files
--------------
src/test/regress/expected/partition_prune.out | 92 ++++++++++++---------------
src/test/regress/sql/partition_prune.sql | 37 +++++------
2 files changed, 55 insertions(+), 74 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-04-17 15:57:14 pgsql: Fix a few typos in comments and variable names.
Previous Message Tom Lane 2018-04-17 15:27:14 pgsql: Add more temporary debug logging, in 9.4 branch only.