pgsql: Ignore whole-rows in INSERT/CONFLICT with partitioned tables

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Ignore whole-rows in INSERT/CONFLICT with partitioned tables
Date: 2018-04-16 19:08:01
Message-ID: E1f89Tt-0001TP-UR@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Ignore whole-rows in INSERT/CONFLICT with partitioned tables

We had an Assert() preventing whole-row expressions from being used in
the SET clause of INSERT ON CONFLICT, but it seems unnecessary, given
some tests, so remove it. Add a new test to exercise the case.

Still at ExecInitPartitionInfo, we used map_partition_varattnos (which
constructs an attribute map, then calls map_variable_attnos) using
the same two relations many times in different expressions and with
different parameters. Constructing the map over and over is a waste.
To avoid this repeated work, construct the map once, and use
map_variable_attnos() directly instead.

Author: Amit Langote, per comments by me (Álvaro)
Discussion: https://postgr.es/m/20180326142016.m4st5e34chrzrknk@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/158b7bc6d77948d2f474dc9f2777c87f81d1365a

Modified Files
--------------
src/backend/executor/execPartition.c | 121 +++++++++++++++++++-------
src/test/regress/expected/insert_conflict.out | 16 ++++
src/test/regress/sql/insert_conflict.sql | 18 ++++
3 files changed, 125 insertions(+), 30 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-04-16 19:41:35 pgsql: Update expected output of new test
Previous Message Tom Lane 2018-04-16 17:44:48 pgsql: Revert "Add temporary debugging assertion, in 9.4 branch only."