From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Clean up callers of JsonbIteratorNext(). |
Date: | 2018-04-15 16:40:06 |
Message-ID: | E1f7khC-0003az-Qg@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Clean up callers of JsonbIteratorNext().
Coverity complained about the lack of a check on the return value in
parse_jsonb_index_flags' last call of JsonbIteratorNext. Seems like
a reasonable gripe to me, especially since the code is depending on
that being WJB_DONE to not leak memory, so add a check.
In passing, improve a couple other places where the result was being
ignored, either by adding an assert or at least a cast to void.
Also, don't spell "WJB_DONE" as "0". That's horrid coding style,
and it wasn't consistent either.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f8a187bdbae6e9d3b7407c0c37e3494518496200
Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-04-15 17:02:32 | pgsql: Fix potentially-unportable code in contrib/adminpack. |
Previous Message | Magnus Hagander | 2018-04-15 12:08:16 | pgsql: Don't attempt to verify checksums on new pages |