pgsql: Improve regression test coverage of expand_tuple().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve regression test coverage of expand_tuple().
Date: 2018-04-14 23:02:37
Message-ID: E1f7UBp-0007M8-Ad@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve regression test coverage of expand_tuple().

I was dissatisfied with the code coverage report for expand_tuple() in the
wake of commit 7c44c46de: while better than no coverage at all, it was
still not exercising the core function of inserting out-of-line default
values, nor was the HeapTuple-output path covered. So far as I can find,
the only code path that reaches the latter at present is EvalPlanQual
fetches for non-locked tables. Hence, extend eval-plan-qual.spec to
test cases where out-of-line defaults must be inserted into a tuple
fetched from a non-locked table.

Discussion: https://postgr.es/m/87woxi24uw.fsf@ansel.ydns.eu

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b39fd897e0398a6bdc6552daa7cacdf9c0e46d7e

Modified Files
--------------
src/test/isolation/expected/eval-plan-qual.out | 20 ++++++++++++++++++++
src/test/isolation/specs/eval-plan-qual.spec | 14 ++++++++++++++
2 files changed, 34 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-04-15 00:15:21 pgsql: Reorganize partitioning code
Previous Message Tom Lane 2018-04-14 19:38:18 pgsql: Fix enforcement of SELECT FOR UPDATE permissions with nested vie