pgsql: Don't clone internal triggers to partitions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't clone internal triggers to partitions
Date: 2018-04-03 22:09:39
Message-ID: E1f3U7X-0008BR-Nb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't clone internal triggers to partitions

Trigger cloning to partitions was supposed to occur for user-visible
triggers only, but during development the protection that prevented it
from occurring to internal triggers was lost. Reinstate it, as well as
add a test case to ensure internal triggers (in the tested case,
triggers implementing a deferred unique constraint) are not cloned.
Without the code fix, the partitions in the test end up with different
numbers of triggers, which is clearly wrong ...

Bug in 86f575948c77.

Discussion: https://postgr.es/m/20180403214903.ozfagwjcpk337uw7@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/851f4b4e143063719553bccc73119a0d29fb1afc

Modified Files
--------------
src/backend/commands/tablecmds.c | 4 ++++
src/test/regress/expected/triggers.out | 23 +++++++++++++++++++++++
src/test/regress/sql/triggers.sql | 15 +++++++++++++++
3 files changed, 42 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Anthony Bykov 2018-04-04 08:10:51 Re: pgsql: Transforms for jsonb to PL/Perl
Previous Message Tom Lane 2018-04-03 21:37:04 Re: pgsql: Transforms for jsonb to PL/Perl