pgsql: Remove contrib/jsonb_plpython's tests for infinity and NaN conve

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove contrib/jsonb_plpython's tests for infinity and NaN conve
Date: 2018-04-02 16:36:30
Message-ID: E1f32Ra-0005w1-FD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove contrib/jsonb_plpython's tests for infinity and NaN conversions.

These tests don't work reliably with pre-2.6 Python versions, since
Python code like float('inf') was not guaranteed to work before that,
even granting an IEEE-compliant platform.

Since there's no explicit handling of these cases in jsonb_plpython,
we're not adding any real code coverage by testing them, and thus
it doesn't seem to make sense to go to any great lengths to work
around the test instability.

Discussion: https://postgr.es/m/E1f1AMU-00031c-9N@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6278a2a262b63faaf47eb2371f6bcb5b6e3ff118

Modified Files
--------------
contrib/jsonb_plpython/expected/jsonb_plpython.out | 40 ----------------------
contrib/jsonb_plpython/sql/jsonb_plpython.sql | 35 -------------------
2 files changed, 75 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-02 16:36:50 Re: pgsql: Transforms for jsonb to PL/Python
Previous Message Tom Lane 2018-04-02 16:26:18 pgsql: Teach configure --with-python to report the Python version numbe