From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve style guideline compliance of assorted error-report mess |
Date: | 2018-03-22 21:33:22 |
Message-ID: | E1ez7pq-0002gy-NT@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve style guideline compliance of assorted error-report messages.
Per the project style guide, details and hints should have leading
capitalization and end with a period. On the other hand, errcontext should
not be capitalized and should not end with a period. To support well
formatted error contexts in dblink, extend dblink_res_error() to take a
format+arguments rather than a hardcoded string.
Daniel Gustafsson
Discussion: https://postgr.es/m/B3C002C8-21A0-4F53-A06E-8CAB29FCF295@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/feb8254518752b2cb4a8964c374dd82d49ef0e0d
Modified Files
--------------
contrib/dblink/dblink.c | 68 ++++++++++++++++++--------
contrib/dblink/expected/dblink.out | 24 ++++-----
contrib/file_fdw/file_fdw.c | 4 +-
contrib/pgcrypto/px.c | 4 +-
contrib/postgres_fdw/connection.c | 2 +-
contrib/postgres_fdw/expected/postgres_fdw.out | 14 +++---
contrib/postgres_fdw/option.c | 2 +-
src/backend/access/transam/xlog.c | 2 +-
src/backend/replication/logical/logical.c | 2 +-
9 files changed, 75 insertions(+), 47 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-03-22 21:50:32 | pgsql: Add FIELDNO_* macro designating offset into structs required for |
Previous Message | Andres Freund | 2018-03-22 21:07:03 | Re: pgsql: Implement partition-wise grouping/aggregation. |