| From: | Andrew Gierth <rhodiumtoad(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Repair crash with unsortable grouping sets. |
| Date: | 2018-03-21 11:43:14 |
| Message-ID: | E1eyc9C-0004Se-Mp@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Repair crash with unsortable grouping sets.
If there were multiple grouping sets, none of them empty, all of which
were unsortable, then an oversight in consider_groupingsets_paths led
to a null pointer dereference. Fix, and add a regression test for this
case.
Per report from Dang Minh Huong, though I didn't use their patch.
Backpatch to 10.x where hashed grouping sets were added.
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cf21c46495897cf3a59f2b1230b522a969a17bea
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 23 ++++++++++++++++++++++-
src/test/regress/expected/groupingsets.out | 12 ++++++++++++
src/test/regress/sql/groupingsets.sql | 5 +++++
3 files changed, 39 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-03-21 11:47:29 | pgsql: Add configure tests for stdbool.h and sizeof bool |
| Previous Message | Teodor Sigaev | 2018-03-21 11:38:01 | pgsql: Rework word_similarity documentation, make it close to actual al |