From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Attempt to fix build with unusual OpenSSL versions |
Date: | 2018-03-20 20:57:53 |
Message-ID: | E1eyOKP-0003hD-6B@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Attempt to fix build with unusual OpenSSL versions
Since e3bdb2d92600ed45bd46aaf48309a436a9628218, libpq failed to build on
some platforms because they did not have SSL_clear_options(). Although
mainline OpenSSL introduced SSL_clear_options() after
SSL_OP_NO_COMPRESSION, so the code should have built fine, at least an
old NetBSD version (build farm "coypu" NetBSD 5.1 gcc 4.1.3 PR-20080704
powerpc) has SSL_OP_NO_COMPRESSION but no SSL_clear_options().
So add a configure check for SSL_clear_options(). If we don't find it,
skip the call. That means on such a platform one cannot *enable* SSL
compression if the built-in default is off, but that seems an unlikely
combination anyway and not very interesting in practice.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a364dfa4ac7337743050256c6eb17b5db5430173
Modified Files
--------------
configure | 2 +-
configure.in | 2 +-
src/include/pg_config.h.in | 3 +++
src/interfaces/libpq/fe-secure-openssl.c | 8 ++++++++
4 files changed, 13 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-03-20 21:00:42 | Re: pgsql: Set libpq sslcompression to off by default |
Previous Message | Andres Freund | 2018-03-20 20:09:15 | pgsql: Add PGAC_PROG_VARCC_VARFLAGS_OPT autoconf macro. |