| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix CommandCounterIncrement in partition-related DDL |
| Date: | 2018-03-20 14:37:36 |
| Message-ID: | E1eyIOO-0004Q4-8z@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Fix CommandCounterIncrement in partition-related DDL
It makes sense to do the CCIs in the places that do catalog updates,
rather than before the places that error out because the former ones
fail to do it. In particular, it looks like StorePartitionBound() and
IndexSetParentIndex() ought to make their own CCIs.
Per review comments from Peter Eisentraut for row-level triggers on
partitioned tables.
Discussion: https://postgr.es/m/20171229225319.ajltgss2ojkfd3kp@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4dba331cb3dc1b5ffb0680ed8efae847de216796
Modified Files
--------------
src/backend/catalog/heap.c | 3 +++
src/backend/commands/indexcmds.c | 3 +++
src/backend/commands/tablecmds.c | 9 ---------
3 files changed, 6 insertions(+), 9 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-03-20 14:54:50 | Re: pgsql: Fix CommandCounterIncrement in partition-related DDL |
| Previous Message | Daniel Gustafsson | 2018-03-20 08:03:35 | Re: pgsql: Set libpq sslcompression to off by default |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-20 14:40:26 | Re: configure's checks for --enable-tap-tests are insufficient |
| Previous Message | Tom Lane | 2018-03-20 14:36:15 | Re: XID-assigned idle transactions affect vacuum's job. |