From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Use ereport not elog for some corrupt-HOT-chain reports. |
Date: | 2018-03-01 21:24:12 |
Message-ID: | E1erVgS-0005as-C3@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Use ereport not elog for some corrupt-HOT-chain reports.
These errors have been seen in the field in corrupted-data situations.
It seems worthwhile to report them with ERRCODE_DATA_CORRUPTED, rather
than the generic ERRCODE_INTERNAL_ERROR, for the benefit of log monitoring
and tools like amcheck. However, use errmsg_internal so that the text
strings still aren't translated; it seems unlikely to be worth
translators' time to do so.
Back-patch to 9.3, like the predecessor commit d70cf811f that introduced
these elog calls originally (replacing Asserts).
Peter Geoghegan
Discussion: https://postgr.es/m/CAH2-Wzmn4-Pg-UGFwyuyK-wiTih9j32pwg_7T9iwqXpAUZr=Mg@mail.gmail.com
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a4fed310cbb4f61fe89b819b82eff8961c647a33
Modified Files
--------------
src/backend/catalog/index.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-03-02 00:29:56 | pgsql: Remove volatile qualifiers from shm_mq.c. |
Previous Message | Alvaro Herrera | 2018-03-01 21:11:18 | pgsql: Relax overly strict sanity check for upgraded ancient databases |