pgsql: Improve regression test coverage of regress.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve regression test coverage of regress.c.
Date: 2018-02-27 17:13:24
Message-ID: E1eqioe-0002Zq-4m@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve regression test coverage of regress.c.

It's a bit silly to have test functions that aren't tested, so test
them.

In passing, rename int44in/int44out to city_budget_in/_out so that they
match how the regression tests use them. Also, fix city_budget_out
so that it emits the format city_budget_in expects to read; otherwise
we'd have dump/reload failures when testing pg_dump against the
regression database. (We avoided that in the past only because no
data of type city_budget was actually stored anywhere.)

Discussion: https://postgr.es/m/29322.1519701006@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be42eb9d624cc14a9326e21ec75fdc571a7cb188

Modified Files
--------------
src/test/regress/expected/create_misc.out | 10 +++++++
src/test/regress/expected/create_operator.out | 8 ++++++
src/test/regress/expected/create_type.out | 13 +++++++--
src/test/regress/input/create_function_1.source | 4 +--
src/test/regress/output/create_function_1.source | 4 +--
src/test/regress/regress.c | 34 +++++++++++-------------
src/test/regress/sql/create_misc.sql | 5 ++++
src/test/regress/sql/create_operator.sql | 4 +++
src/test/regress/sql/create_type.sql | 8 ++++--
9 files changed, 63 insertions(+), 27 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-02-27 18:27:49 pgsql: Fix logic error in add_paths_to_partial_grouping_rel.
Previous Message Magnus Hagander 2018-02-27 13:13:53 pgsql: Revert restructuring of bin/scripts/Makefile