From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Check error messages in SSL tests |
Date: | 2018-02-24 15:11:30 |
Message-ID: | E1epbU2-0007rq-V4@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Check error messages in SSL tests
In tests that check whether a connection fails, also check the error
message. That makes sure that the connection was rejected for the right
reason.
This discovered that two tests had their connection failing for the
wrong reason. One test failed because pg_hba.conf was not set up to
allow that user, one test failed because the client key file did not
have the right permissions. Fix those tests and add a new one that is
really supposed to check the file permission issue.
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/081bfc19b3b7914b78eb44e00af9dd45325dda3e
Modified Files
--------------
src/test/ssl/ServerSetup.pm | 42 ++++++++++++++++-------------------------
src/test/ssl/ssl/.gitignore | 2 +-
src/test/ssl/t/001_ssltests.pl | 43 ++++++++++++++++++++++++++++++++++++++----
src/test/ssl/t/002_scram.pl | 4 +++-
4 files changed, 59 insertions(+), 32 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-02-24 18:23:50 | pgsql: Add window RANGE support for float4, float8, numeric. |
Previous Message | Peter Eisentraut | 2018-02-24 03:14:05 | pgsql: Fix filtering of unsupported relations in logical replication |