From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Silence assorted "variable may be used uninitialized" warnings. |
Date: | 2018-02-14 21:06:58 |
Message-ID: | E1em4GY-0001Qa-CE@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Silence assorted "variable may be used uninitialized" warnings.
All of these are false positives, but in each case a fair amount of
analysis is needed to see that, and it's not too surprising that not all
compilers are smart enough. (In particular, in the logtape.c case, a
compiler lacking the knowledge provided by the Assert would almost surely
complain, so that this warning will be seen in any non-assert build.)
Some of these are of long standing while others are pretty recent,
but it only seems worth fixing them in HEAD.
Jaime Casanova, tweaked a bit by me
Discussion: https://postgr.es/m/CAJGNTeMcYAMJdPAom52dppLMtF-UnEZi0dooj==75OEv1EoBZA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9a725f7b5cb7e8c8894ef121b49eff9c265245c8
Modified Files
--------------
src/backend/access/transam/xloginsert.c | 2 +-
src/backend/catalog/objectaddress.c | 2 ++
src/backend/utils/sort/logtape.c | 2 +-
src/bin/pgbench/pgbench.c | 7 ++++---
4 files changed, 8 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-02-14 22:30:24 | pgsql: Return implementation defined value if pg_$op_s$bit_overflow ove |
Previous Message | Tom Lane | 2018-02-14 20:06:08 | pgsql: Add an assertion that we don't pass NULL to snprintf("%s"). |