pgsql: Improve implementation of pg_attribute_always_inline.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve implementation of pg_attribute_always_inline.
Date: 2018-01-24 04:07:25
Message-ID: E1eeCLN-0007My-3X@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve implementation of pg_attribute_always_inline.

Avoid compiler warnings on MSVC (which doesn't want to see both
__forceinline and inline) and ancient GCC (which doesn't have
__attribute__((always_inline))).

Don't force inline-ing when building at -O0, as the programmer is probably
hoping for exact source-to-object-line correspondence in that case.
(For the moment this only works for GCC; maybe we can extend it later.)

Make pg_attribute_always_inline be syntactically a drop-in replacement
for inline, rather than an additional wart.

And improve the comments.

Thomas Munro and Michail Nikolaev, small tweaks by me

Discussion: https://postgr.es/m/32278.1514863068@sss.pgh.pa.us
Discussion: https://postgr.es/m/CANtu0oiYp74brgntKOxgg1FK5+t8uQ05guSiFU6FYz_5KUhr6Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/434e6e1484418c55561914600de9e180fc408378

Modified Files
--------------
src/backend/executor/nodeHashjoin.c | 3 +--
src/include/c.h | 17 ++++++++++++-----
2 files changed, 13 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-01-24 18:11:22 Re: pgsql: Add parallel-aware hash joins.
Previous Message Amit Kapila 2018-01-24 02:56:45 Re: pgsql: Allow UPDATE to move rows between partitions.