pgsql: Replace AclObjectKind with ObjectType

Replace AclObjectKind with ObjectType

AclObjectKind was basically just another enumeration for object types,
and we already have a preferred one for that. It's only used in
aclcheck_error. By using ObjectType instead, we can also give some more
precise error messages, for example "index" instead of "relation".

Reviewed-by: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8b9e9644dc6a9bd4b7a97950e6212f63880cf18b

Modified Files
--------------
contrib/dblink/dblink.c | 4 +-
contrib/file_fdw/output/file_fdw.source | 2 +-
contrib/pg_prewarm/pg_prewarm.c | 2 +-
contrib/pgrowlocks/pgrowlocks.c | 2 +-
contrib/test_decoding/expected/permissions.out | 4 +-
src/backend/access/brin/brin.c | 4 +-
src/backend/access/gin/ginfast.c | 2 +-
src/backend/catalog/aclchk.c | 505 +++++++++++++--------
src/backend/catalog/namespace.c | 8 +-
src/backend/catalog/objectaddress.c | 125 +++--
src/backend/catalog/pg_aggregate.c | 2 +-
src/backend/catalog/pg_operator.c | 8 +-
src/backend/catalog/pg_proc.c | 2 +-
src/backend/catalog/pg_type.c | 2 +-
src/backend/commands/aggregatecmds.c | 2 +-
src/backend/commands/alter.c | 18 +-
src/backend/commands/collationcmds.c | 4 +-
src/backend/commands/conversioncmds.c | 4 +-
src/backend/commands/dbcommands.c | 16 +-
src/backend/commands/event_trigger.c | 4 +-
src/backend/commands/extension.c | 8 +-
src/backend/commands/foreigncmds.c | 16 +-
src/backend/commands/functioncmds.c | 26 +-
src/backend/commands/indexcmds.c | 10 +-
src/backend/commands/lockcmds.c | 4 +-
src/backend/commands/opclasscmds.c | 16 +-
src/backend/commands/operatorcmds.c | 10 +-
src/backend/commands/policy.c | 2 +-
src/backend/commands/proclang.c | 4 +-
src/backend/commands/publicationcmds.c | 10 +-
src/backend/commands/schemacmds.c | 10 +-
src/backend/commands/statscmds.c | 2 +-
src/backend/commands/subscriptioncmds.c | 6 +-
src/backend/commands/tablecmds.c | 36 +-
src/backend/commands/tablespace.c | 10 +-
src/backend/commands/trigger.c | 8 +-
src/backend/commands/tsearchcmds.c | 8 +-
src/backend/commands/typecmds.c | 28 +-
src/backend/commands/user.c | 2 +-
src/backend/executor/execExpr.c | 4 +-
src/backend/executor/execMain.c | 2 +-
src/backend/executor/execSRF.c | 2 +-
src/backend/executor/nodeAgg.c | 10 +-
src/backend/executor/nodeWindowAgg.c | 8 +-
src/backend/parser/parse_utilcmd.c | 4 +-
src/backend/rewrite/rewriteDefine.c | 6 +-
src/backend/tcop/fastpath.c | 4 +-
src/backend/utils/adt/dbsize.c | 4 +-
src/backend/utils/adt/tid.c | 4 +-
src/backend/utils/fmgr/fmgr.c | 4 +-
src/include/catalog/objectaddress.h | 4 +-
src/include/utils/acl.h | 35 +-
src/pl/tcl/pltcl.c | 2 +-
.../dummy_seclabel/expected/dummy_seclabel.out | 4 +-
src/test/regress/expected/alter_table.out | 18 +-
src/test/regress/expected/copy2.out | 6 +-
src/test/regress/expected/create_procedure.out | 2 +-
src/test/regress/expected/lock.out | 2 +-
src/test/regress/expected/privileges.out | 152 +++----
src/test/regress/expected/publication.out | 2 +-
src/test/regress/expected/rowsecurity.out | 18 +-
src/test/regress/expected/select_into.out | 6 +-
src/test/regress/expected/sequence.out | 2 +-
src/test/regress/expected/updatable_views.out | 30 +-
src/test/regress/sql/alter_table.sql | 21 +
65 files changed, 742 insertions(+), 550 deletions(-)