From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Add QueryEnvironment to ExplainOneQuery_hook's parameter list. |
Date: | 2018-01-11 17:16:24 |
Message-ID: | E1eZgSm-00075r-IF@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add QueryEnvironment to ExplainOneQuery_hook's parameter list.
This should have been done in commit 18ce3a4ab, which added that parameter
to ExplainOneQuery, but it was overlooked. This makes it impossible for
a user of the hook to pass the queryEnv down to ExplainOnePlan.
It's too late to change this API in v10, I suppose, but fortunately
passing NULL to ExplainOnePlan will work in nearly all interesting
cases in v10. That might not be true forever, so we'd better fix it.
Tatsuro Yamada, reviewed by Thomas Munro
Discussion: https://postgr.es/m/890e8dd9-c1c7-a422-6892-874f5eaee048@lab.ntt.co.jp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4d41b2e0926548e338d20875729a55d41289f867
Modified Files
--------------
src/backend/commands/explain.c | 2 +-
src/include/commands/explain.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-01-11 18:39:04 | pgsql: Refactor subscription tests to use PostgresNode's wait_for_catch |
Previous Message | Tom Lane | 2018-01-11 16:54:03 | pgsql: Cosmetic fix in postgres_fdw.c. |