From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Update portal-related memory context names and API |
Date: | 2018-01-09 18:59:41 |
Message-ID: | E1eYz7d-00070K-Lf@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Update portal-related memory context names and API
Rename PortalMemory to TopPortalContext, to avoid confusion with
PortalContext and align naming with similar top-level memory contexts.
Rename PortalData's "heap" field to portalContext. The "heap" naming
seems quite antiquated and confusing. Also get rid of the
PortalGetHeapMemory() macro and access the field directly, which we do
for other portal fields, so this abstraction doesn't buy anything.
Reviewed-by: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0f7c49e85518dd846ccd0a044d49a922b9132983
Modified Files
--------------
src/backend/commands/portalcmds.c | 10 +++++-----
src/backend/commands/prepare.c | 2 +-
src/backend/executor/spi.c | 6 +++---
src/backend/tcop/postgres.c | 2 +-
src/backend/tcop/pquery.c | 16 ++++++++--------
src/backend/utils/mmgr/portalmem.c | 32 ++++++++++++++++----------------
src/include/utils/portal.h | 3 +--
7 files changed, 35 insertions(+), 36 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2018-01-09 19:30:43 | pgsql: Implement TZH and TZM timestamp format patterns |
Previous Message | Tom Lane | 2018-01-09 18:25:59 | pgsql: Improve the heuristic for ordering child paths of a parallel app |