| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: pg_upgrade: prevent check on live cluster from generating error |
| Date: | 2018-01-09 03:44:01 |
| Message-ID: | E1eYkpV-00067E-OR@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_upgrade: prevent check on live cluster from generating error
Previously an inaccurate but harmless error was generated when running
--check on a live server before reporting the servers as compatible.
The fix is to split error reporting and exit control in the exec_prog()
API.
Reported-by: Daniel Westermann
Backpatch-through: 10
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d25ee30031b08ad1348a090914c2af6bc640a832
Modified Files
--------------
src/bin/pg_upgrade/dump.c | 2 +-
src/bin/pg_upgrade/exec.c | 14 ++++++--------
src/bin/pg_upgrade/parallel.c | 9 ++++-----
src/bin/pg_upgrade/pg_upgrade.c | 24 ++++++++++++------------
src/bin/pg_upgrade/pg_upgrade.h | 6 +++---
src/bin/pg_upgrade/server.c | 18 +++++++++---------
6 files changed, 35 insertions(+), 38 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-09 14:46:18 | pgsql: Fix comment. |
| Previous Message | Tom Lane | 2018-01-08 23:28:13 | pgsql: Improve error detection capability in proclists. |