pgsql: Code review for Parallel Append.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for Parallel Append.
Date: 2018-01-04 12:58:55
Message-ID: E1eX56l-00085r-GD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review for Parallel Append.

- Remove unnecessary #include mistakenly added in execnodes.h.
- Fix mistake in comment in choose_next_subplan_for_leader.
- Adjust row estimates in cost_append for a possibly-different
parallel divisor.
- Clamp row estimates in cost_append after operations that may
not produce integers.

Amit Kapila, with cosmetic adjustments by me.

Discussion: http://postgr.es/m/CAA4eK1+qcbeai3coPpRW=GFCzFeLUsuY4T-AKHqMjxpEGZBPQg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c759395617765c5bc21db149cf8c3df52f41ccff

Modified Files
--------------
src/backend/executor/nodeAppend.c | 7 +++----
src/backend/optimizer/path/costsize.c | 16 ++++++++++++----
src/include/nodes/execnodes.h | 1 -
3 files changed, 15 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-01-04 15:52:21 pgsql: Define LDAPS_PORT if it's missing and disable implicit LDAPS on
Previous Message Tom Lane 2018-01-04 06:09:33 Re: pgsql: Add parallel-aware hash joins.