pgsql: Fix crashes on plans with multiple Gather (Merge) nodes.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix crashes on plans with multiple Gather (Merge) nodes.
Date: 2017-12-18 17:34:07
Message-ID: E1eQzIl-0004wM-K3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix crashes on plans with multiple Gather (Merge) nodes.

es_query_dsa turns out to be broken by design, because it supposes
that there is only one DSA for the whole query, whereas there is
actually one per Gather (Merge) node. For now, work around that
problem by setting and clearing the pointer around the sections of
code that might need it. It's probably a better idea to get rid of
es_query_dsa altogether in favor of having each node keep track
individually of which DSA is relevant, but that seems like more than
we would want to back-patch.

Thomas Munro, reviewed and tested by Andreas Seltenreich, Amit
Kapila, and by me.

Discussion: http://postgr.es/m/CAEepm=1U6as=brnVvMNixEV2tpi8NuyQoTmO8Qef0-VV+=7MDA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd7c0fa732d97a4b4ebb58730e6244ea30d0a618

Modified Files
--------------
src/backend/executor/execParallel.c | 26 ++++++++++++++------------
src/backend/executor/nodeGather.c | 6 ++++++
src/backend/executor/nodeGatherMerge.c | 4 ++++
3 files changed, 24 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2017-12-18 18:50:45 pgsql: Fix bug in cancellation of non-exclusive backup to avoid asserti
Previous Message Andres Freund 2017-12-18 16:40:06 Re: pgsql: Provide overflow safe integer math inline functions.