pgsql: Fix corner-case coredump in _SPI_error_callback().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix corner-case coredump in _SPI_error_callback().
Date: 2017-12-11 21:34:41
Message-ID: E1eOVij-0000eh-0B@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix corner-case coredump in _SPI_error_callback().

I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,
and only fills it in some time later. If an error were to happen in
between, _SPI_error_callback would try to dereference the null pointer.
This is unlikely --- there's not much between those points except
push-snapshot calls --- but it's clearly not impossible. Tweak the
callback to do nothing if the pointer isn't set yet.

It's been like this for awhile, so back-patch to all supported branches.

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/239b01e313b5c3bc90d383b0a345e0549fe9ba96

Modified Files
--------------
src/backend/executor/spi.c | 3 +++
1 file changed, 3 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-12-11 21:39:04 pgsql: Fix comment
Previous Message Tom Lane 2017-12-11 21:34:40 pgsql: Fix corner-case coredump in _SPI_error_callback().