From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Pass eflags down to parallel workers. |
Date: | 2017-11-20 17:03:41 |
Message-ID: | E1eGpTx-0008Bw-BC@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Pass eflags down to parallel workers.
Currently, there are no known consequences of this oversight, so no
back-patch. Several of the EXEC_FLAG_* constants aren't usable in
parallel mode anyway, and potential problems related to the presence
or absence of OIDs (see EXEC_FLAG_WITH_OIDS, EXEC_FLAG_WITHOUT_OIDS)
seem at present to be masked by the unconditional projection step
performed by Gather and Gather Merge. In general, however, it seems
important that all participants agree on the values of these flags,
which modify executor behavior globally, and a pending patch to skip
projection in Gather (Merge) would be outright broken in certain cases
without this fix.
Patch by me, based on investigation of a test case provided by Amit
Kapila. This patch was also reviewed by Amit Kapila.
Discussion: http://postgr.es/m/CA+TgmoZ0ZL=cesZFq8c9NnfK6bqy-wwUd3_74iYGodYrSoQ7Fw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f455e1125e2588d4cd4fc663c6a10da4e003a3b5
Modified Files
--------------
src/backend/executor/execParallel.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-11-20 17:34:25 | pgsql: Tweak use of ExecContextForcesOids by Gather (Merge). |
Previous Message | Amit Kapila | 2017-11-20 13:38:28 | Re: [COMMITTERS] pgsql: Remove secondary checkpoint |