pgsql: Define _WINSOCK_DEPRECATED_NO_WARNINGS in all MSVC builds.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Define _WINSOCK_DEPRECATED_NO_WARNINGS in all MSVC builds.
Date: 2017-11-16 17:03:08
Message-ID: E1eFNZE-0006FH-UY@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Define _WINSOCK_DEPRECATED_NO_WARNINGS in all MSVC builds.

Commit 0fb54de9a thought that this was only needed in VS2015 and later,
but buildfarm member woodlouse shows that at least VS2013 whines as
well. Let's just define it regardless of MSVC version; it should be
harmless enough in older releases.

Also, in the wake of ed9b3606d, it seems better to put it in win32_port.h
where <winsock2.h> is included.

Since this is only suppressing a pedantic compiler warning, I don't
feel a need for a back-patch.

Discussion: https://postgr.es/m/20124.1510850225@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ff2d4356f8b18f5489e5d7b1f8b4b5357d088c8c

Modified Files
--------------
src/include/port/win32.h | 3 ---
src/include/port/win32_port.h | 8 ++++++++
2 files changed, 8 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-11-16 17:06:55 pgsql: Pass InitPlan values to workers via Gather (Merge).
Previous Message Fabrízio de Royes Mello 2017-11-16 17:00:31 Re: pgsql: Add hooks for session start and session end