| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte |
| Date: | 2017-11-12 21:09:42 |
| Message-ID: | E1eDzVe-0000Y4-V8@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.
PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit(). This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7. Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect. Back-patch
to 9.3 (all supported versions).
Takayuki Tsunakawa, reviewed by Michael Paquier.
Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d74db7a35c8dd18342fdf403375af55e2561e61e
Modified Files
--------------
src/backend/utils/error/elog.c | 5 +++++
src/backend/utils/mb/mbutils.c | 6 ++++--
2 files changed, 9 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-11-12 22:31:59 | pgsql: Install Windows crash dump handler before all else. |
| Previous Message | Noah Misch | 2017-11-11 22:54:13 | pgsql: Add post-2010 ecpg tests to checktcp. |