pgsql: Fix bogus logic for checking executables' versions within pg_upg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bogus logic for checking executables' versions within pg_upg
Date: 2017-11-09 16:30:42
Message-ID: E1eCpj0-0003H8-9e@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus logic for checking executables' versions within pg_upgrade.

Somebody messed up a refactoring here. As it stood, we'd check pg_ctl's
--version output twice for each cluster. Worse, the first check for the
new cluster's version happened before we'd done any validate_exec checks
there, breaking the check ordering the code intended.

A. Akenteva

Discussion: https://postgr.es/m/f9266a85d918a3cf3a386b5148aee666@postgrespro.ru

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/115a7075633899408fc1ab85f3bc2e5deeaa5e45

Modified Files
--------------
src/bin/pg_upgrade/exec.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-11-09 16:57:49 pgsql: Fix typo in ALTER SYSTEM output.
Previous Message Tom Lane 2017-11-09 16:00:59 pgsql: Revert "Allow --with-bonjour to work with non-macOS implementati