From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix ALTER TABLE code to update domain constraints when needed. |
Date: | 2017-11-01 17:32:29 |
Message-ID: | E1e9wsP-0006Qx-2C@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix ALTER TABLE code to update domain constraints when needed.
It's possible for dropping a column, or altering its type, to require
changes in domain CHECK constraint expressions; but the code was
previously only expecting to find dependent table CHECK constraints.
Make the necessary adjustments.
This is a fairly old oversight, but it's a lot easier to encounter
the problem in the context of domains over composite types than it
was before. Given the lack of field complaints, I'm not going to
bother with a back-patch, though I'd be willing to reconsider that
decision if someone does complain.
Patch by me, reviewed by Michael Paquier
Discussion: https://postgr.es/m/30656.1509128130@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af20e2d728eb508bb169e7294e4e210a3459833a
Modified Files
--------------
src/backend/commands/tablecmds.c | 98 ++++++++++++++++++++++++++++++------
src/backend/utils/adt/ruleutils.c | 67 ++++++++++++++++++++----
src/include/nodes/parsenodes.h | 1 +
src/test/regress/expected/domain.out | 25 +++++++++
src/test/regress/sql/domain.sql | 20 ++++++++
5 files changed, 186 insertions(+), 25 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-11-01 18:35:50 | pgsql: doc: Mention pg_stat_wal_receiver in streaming replication docs |
Previous Message | Peter Eisentraut | 2017-11-01 14:52:53 | pgsql: doc: Add to hot standby documentation |