pgsql: Dept of second thoughts: keep aliasp_item in sync with tlistitem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Dept of second thoughts: keep aliasp_item in sync with tlistitem
Date: 2017-10-27 22:17:07
Message-ID: E1e8Cw7-0000z6-6s@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Dept of second thoughts: keep aliasp_item in sync with tlistitem.

Commit d5b760ecb wasn't quite right, on second thought: if the
caller didn't ask for column names then it would happily emit
more Vars than if the caller did ask for column names. This
is surely not a good idea. Advance the aliasp_item whether or
not we're preparing a colnames list.

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/21daada10ebf444fb1fc06a705fb22b890867083

Modified Files
--------------
src/backend/parser/parse_relation.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-10-28 09:13:02 pgsql: Fix misplaced ReleaseSysCache call in get_default_partition_oid.
Previous Message Tom Lane 2017-10-27 21:29:08 pgsql: Fix crash when columns have been added to the end of a view.