From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Allow parallel query for prepared statements with generic plans. |
Date: | 2017-10-27 20:32:14 |
Message-ID: | E1e8BIc-00081b-8V@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Allow parallel query for prepared statements with generic plans.
This was always intended to work, but due to an oversight in
max_parallel_hazard_walker, it didn't. In testing, we missed the
fact that it was only working for custom plans, where the parameter
value has been substituted for the parameter itself early enough
that everything worked. In a generic plan, the Param node survives
and must be treated as parallel-safe. SerializeParamList provides
for the transmission of parameter values to workers.
Amit Kapila with help from Kuntal Ghosh. Some changes by me.
Discussion: http://postgr.es/m/CAA4eK1+_BuZrmVCeua5Eqnm4Co9DAXdM5HPAOE2J19ePbR912Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/682ce911f8f30de39b13cf211fc8ceb8c6cbc01b
Modified Files
--------------
src/backend/optimizer/util/clauses.c | 8 ++++++--
src/pl/plpgsql/src/pl_exec.c | 10 +++++-----
src/test/regress/expected/select_parallel.out | 20 ++++++++++++++++++++
src/test/regress/sql/select_parallel.sql | 6 ++++++
4 files changed, 37 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-10-27 21:29:08 | pgsql: Fix crash when columns have been added to the end of a view. |
Previous Message | Tom Lane | 2017-10-27 16:19:25 | pgsql: Rethink the dependencies recorded for FieldSelect/FieldStore nod |