pgsql: Process variadic arguments consistently in json functions

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Process variadic arguments consistently in json functions
Date: 2017-10-25 12:24:21
Message-ID: E1e7KjN-0001qs-Hz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Process variadic arguments consistently in json functions

json_build_object and json_build_array and the jsonb equivalents did not
correctly process explicit VARIADIC arguments. They are modified to use
the new extract_variadic_args() utility function which abstracts away
the details of the call method.

Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov.

Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as
that's where they originated.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/18fc4ecf4afafe40bd7e7577bd611e5caf74c9fd

Modified Files
--------------
src/backend/utils/adt/json.c | 84 ++++++++--------------------
src/backend/utils/adt/jsonb.c | 99 ++++++++++-----------------------
src/test/regress/expected/json.out | 107 ++++++++++++++++++++++++++++++++++++
src/test/regress/expected/jsonb.out | 105 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/json.sql | 21 +++++++
src/test/regress/sql/jsonb.sql | 22 +++++++-
6 files changed, 306 insertions(+), 132 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-10-25 23:32:55 pgsql: Fix libpq to not require user's home directory to exist.
Previous Message Andrew Dunstan 2017-10-25 12:24:18 pgsql: Process variadic arguments consistently in json functions

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-10-25 13:12:36 Re: CurTransactionContext freed before transaction COMMIT ???
Previous Message Amit Kapila 2017-10-25 11:59:56 Re: Pluggable storage