| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Improve implementation of CRE-stack-flattening in map_variable_a |
| Date: | 2017-10-13 17:44:01 |
| Message-ID: | E1e3409-0008Qf-HW@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve implementation of CRE-stack-flattening in map_variable_attnos().
I (tgl) objected to the obscure implementation introduced in commit
1c497fa72. This one seems a bit less action-at-a-distance-y, at the
price of repeating a few lines of code.
Improve the comments about what the function is doing, too.
Amit Khandekar, whacked around a bit more by me
Discussion: https://postgr.es/m/CAJ3gD9egYTyHUH0nTMxm8-1m3RvdqEbaTyGC-CUNtYf7tKNDaQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/73937119bfd07a140da4817f5ca949351942ffdc
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 101 ++++++++++++++++++++-----------------
1 file changed, 55 insertions(+), 46 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-10-13 17:48:07 | Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage. |
| Previous Message | Peter Geoghegan | 2017-10-13 16:38:54 | Re: [COMMITTERS] pgsql: Fix traversal of half-frozen update chains |