From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: #ifdef out some dead code in psql/mainloop.c. |
Date: | 2017-10-06 15:36:11 |
Message-ID: | E1e0Ufb-0007Kt-89@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
#ifdef out some dead code in psql/mainloop.c.
This pg_send_history() call is unreachable, since the block it's in
is currently only entered in !cur_cmd_interactive mode. But rather
than just delete it, make it #ifdef NOT_USED, in hopes that we'll
remember to enable it if we ever change that decision.
Per report from David Binderman. Since this is basically cosmetic,
I see no great need to back-patch.
Discussion: https://postgr.es/m/HE1PR0802MB233122B61F00A15E035C83BE9C710@HE1PR0802MB2331.eurprd08.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3620569fecc6c2edb1cccfbba39b86c4e7d2faae
Modified Files
--------------
src/bin/psql/mainloop.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-10-06 15:40:41 | pgsql: Run coverage commands quietly |
Previous Message | Alvaro Herrera | 2017-10-06 15:29:30 | pgsql: Fix traversal of half-frozen update chains |