From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix behavior when converting a float infinity to numeric. |
Date: | 2017-09-27 21:06:14 |
Message-ID: | E1dxJX4-0004wY-2q@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix behavior when converting a float infinity to numeric.
float8_numeric() and float4_numeric() failed to consider the possibility
that the input is an IEEE infinity. The results depended on the
platform-specific behavior of sprintf(): on most platforms you'd get
something like
ERROR: invalid input syntax for type numeric: "inf"
but at least on Windows it's possible for the conversion to succeed and
deliver a finite value (typically 1), due to a nonstandard output format
from sprintf and lack of syntax error checking in these functions.
Since our numeric type lacks the concept of infinity, a suitable conversion
is impossible; the best thing to do is throw an explicit error before
letting sprintf do its thing.
While at it, let's use snprintf not sprintf. Overrunning the buffer
should be impossible if sprintf does what it's supposed to, but this
is cheap insurance against a stack smash if it doesn't.
Problem reported by Taiki Kondo. Patch by me based on fix suggestion
from KaiGai Kohei. Back-patch to all supported branches.
Discussion: https://postgr.es/m/12A9442FBAE80D4E8953883E0B84E088C8C7A2@BPXM01GP.gisp.nec.co.jp
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/07ea925e20ee80898638800c8479b48e7e97d431
Modified Files
--------------
src/backend/utils/adt/numeric.c | 14 ++++++++++++--
src/test/regress/expected/numeric.out | 21 +++++++++++++++++++++
src/test/regress/sql/numeric.sql | 8 ++++++++
3 files changed, 41 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-09-28 06:17:02 | PartitionSchemaData & partcollation (Re: [COMMITTERS] pgsql: Associate partitioning information with each RelOptInfo.) |
Previous Message | Tom Lane | 2017-09-27 20:14:56 | pgsql: Revert to 9.6 treatment of ALTER TYPE enumtype ADD VALUE. |