From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix failure-to-read-man-page in commit 899bd785c. |
Date: | 2017-09-26 17:43:26 |
Message-ID: | E1dwttG-00068U-MB@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix failure-to-read-man-page in commit 899bd785c.
posix_fallocate() is not quite a drop-in replacement for fallocate(),
because it is defined to return the error code as its function result,
not in "errno". I (tgl) missed this because RHEL6's version seems
to set errno as well. That is not the case on more modern Linuxen,
though, as per buildfarm results.
Aside from fixing the return-convention confusion, remove the test
for ENOSYS; we expect that glibc will mask that for posix_fallocate,
though it does not for fallocate. Keep the test for EINTR, because
POSIX specifies that as a possible result, and buildfarm results
suggest that it can happen in practice.
Back-patch to 9.4, like the previous commit.
Thomas Munro
Discussion: https://postgr.es/m/1002664500.12301802.1471008223422.JavaMail.yahoo@mail.yahoo.com
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/06852f21544c061cb4d4b53bbe16a647a12dd311
Modified Files
--------------
src/backend/storage/ipc/dsm_impl.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-09-26 19:09:55 | Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu |
Previous Message | Tom Lane | 2017-09-26 17:15:05 | pgsql: Remove heuristic same-transaction test from check_safe_enum_use( |