pgsql: Remove lsn from HashScanPosData.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove lsn from HashScanPosData.
Date: 2017-09-26 13:26:51
Message-ID: E1dwpsx-00015a-Nc@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove lsn from HashScanPosData.

This was intended as infrastructure for weakening VACUUM's locking
requirements, similar to what was done for btree indexes in commit
2ed5b87f96d473962ec5230fd820abfeaccb2069. However, for hash indexes,
it seems that the improvements which are possible are actually
extremely marginal. Furthermore, performing the LSN cross-check will
end up skipping cleanup far more often than is necessary; we only care
about page modifications due to a VACUUM, but the LSN check will fail
if ANY modification has occurred. So, rather than pressing forward
with that "optimization", just rip the LSN field out.

Patch by me, reviewed by Ashutosh Sharma and Amit Kapila

Discussion: http://postgr.es/m/CAA4eK1JxqqcuC5Un7YLQVhOYSZBS+t=3xqZuEkt5RyquyuxpwQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/22c5e73562c53437979efec4c26cd9fff408777c

Modified Files
--------------
src/backend/access/hash/hashsearch.c | 8 --------
src/backend/access/hash/hashutil.c | 27 +++++++--------------------
src/include/access/hash.h | 2 --
3 files changed, 7 insertions(+), 30 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-09-26 14:30:46 pgsql: Handle heap rewrites better in logical replication
Previous Message Robert Haas 2017-09-26 13:02:04 pgsql: Fix trivial mistake in README.