pgsql: Fix pg_basebackup test to original intent

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_basebackup test to original intent
Date: 2017-09-24 03:06:17
Message-ID: E1dvxFJ-0000uK-R3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_basebackup test to original intent

One test case was meant to check that pg_basebackup does not succeed
when a slot is specified with -S but WAL streaming is not selected,
which used to require specifying -X stream. Since -X stream is the
default in PostgreSQL 10, this test case no longer covers that meaning,
but the pg_basebackup invocation happened to fail anyway for the
unrelated reason that the specified replication slot does not exist. To
fix, move the test case to later in the file where the slot does exist,
and add -X none to the invocation so that it covers the originally meant
behavior.

extracted from a patch by Michael Banck <michael(dot)banck(at)credativ(dot)de>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/74ca8f9b9077017529fe658e445a11da296ac6ab

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-09-24 04:42:23 pgsql: doc: Expand user documentation on SCRAM
Previous Message Tom Lane 2017-09-23 20:01:51 Re: pgsql: Remove pgbench "progress" test pending solution of its timing is